Repository navigation
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #1371 +/- ##
===========================================
+ Coverage 7.85% 13.94% +6.08%
===========================================
Files 1125 1139 +14
Lines 112820 114726 +1906
===========================================
+ Hits 8866 16000 +7134
+ Misses 103954 98726 -5228 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Converting to draft because I have too many open PRs ready--will take another review pass over this before re-readying it |
sneurlax
marked this pull request as draft
August 20, 2026 18:58
Running an AppImage with --portable, or placing an <AppImage>.portable marker file beside it, keeps the data root, secure store and logs in <AppImage dir>/.<app data dir> instead of the home directory. An existing directory beside the AppImage is never on its own treated as consent. An explicit -d <dir> stays authoritative wherever it appears in argv; -d without a directory and --portable outside an AppImage are usage errors that exit 64 instead of opening an empty window. closes #1177
sneurlax
force-pushed
the
feat/1177-portable-appimage
branch
from
August 24, 2026 21:31
63d8f60 to
f377711
Compare
Running an AppImage with --portable, or placing an <AppImage>.portable marker file beside it, keeps the data root, secure store and logs in <AppImage dir>/.<app data dir> instead of the home directory. An existing directory beside the AppImage is never on its own treated as consent. An explicit -d <dir> stays authoritative wherever it appears in argv; -d without a directory and --portable outside an AppImage are usage errors that exit 64 instead of opening an empty window. closes #1177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1177
Refresh review (2026-11-10)
Refresh review fixed desktop data-directory argument handling: an explicit
-doverride remains valid with--portableoutside AppImage, while portable mode still requires AppImage without an override. Added regression coverage.Checks:
flutter test test/utilities/stack_file_system_test.dart(13 passed). Static analysis found no warnings or errors in changed files; remaining diagnostics are informational baseline style notices.